Skip to content

Make tests blocking#263

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:blocking
Jun 4, 2026
Merged

Make tests blocking#263
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:blocking

Conversation

@mandre
Copy link
Copy Markdown
Member

@mandre mandre commented Jun 1, 2026

The migration tools made them informing by default. Restore their blocking behavior.

The migration tools made them informing by default. Restore their
blocking behavior.
@openshift-ci openshift-ci Bot requested review from eshulman2 and stephenfin June 1, 2026 12:41
@mandre
Copy link
Copy Markdown
Member Author

mandre commented Jun 1, 2026

@mandre
Copy link
Copy Markdown
Member Author

mandre commented Jun 2, 2026

/retest

@ekuris-redhat
Copy link
Copy Markdown

/test test

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ekuris-redhat
Copy link
Copy Markdown

This PR is changing OpenShift's test framework to be in "Blocking", which means failures actively gate merges/releases
/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@stephenfin
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@stephenfin
Copy link
Copy Markdown
Contributor

/verified bypass

We'll see the effect of this in CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@stephenfin: The verified label has been added.

Details

In response to this:

/verified bypass

We'll see the effect of this in CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekuris-redhat, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 13c876a into openshift:main Jun 4, 2026
5 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the blocking branch June 4, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants